Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Feat/optional intl polyfill #1256

Closed

Conversation

timBarton96
Copy link
Member

Description

Added an environment variable to conditionally add the lean-intl polyfill.

Motivation and Context

The lean-intl polyfill is missing Intl fetres and this PR is for consumers of one-app that want to trade compatibility with older browsers for these Intl features. The environment variable defaults to enable lean-intl polyfill, so needs to be explicitly be disabled. By disalbing the polyfill, the Intl implementations of the browsers are used and for modern browsers, this means extended functionality.

How Has This Been Tested?

I served a test-module which uses Luxon which uses Intl for its timezones functionality. The timezones would not work without the env var, but when the env var is enabled and there is no lean-intl the timezones work.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Developers will now have the option to opt out of using lean-intl.

@timBarton96 timBarton96 requested review from a team as code owners January 24, 2024 16:57
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@giulianok giulianok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are too many unrelated and reverted changes, looks like the branch isn't up to date

@timBarton96 timBarton96 force-pushed the feat/optionalIntlPolyfill branch from 5361ddd to 8f2b89e Compare January 25, 2024 09:44
@timBarton96
Copy link
Member Author

Closing this PR as it is out of sync with main and my attempts to fix have taken more effort than just opening a new branch and PR. New PR here: #1258

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants