This repository has been archived by the owner on May 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an environment variable to conditionally add the lean-intl polyfill.
Motivation and Context
The lean-intl polyfill is missing Intl fetres and this PR is for consumers of one-app that want to trade compatibility with older browsers for these Intl features. The environment variable defaults to enable lean-intl polyfill, so needs to be explicitly be disabled. By disalbing the polyfill, the Intl implementations of the browsers are used and for modern browsers, this means extended functionality.
How Has This Been Tested?
I served a test-module which uses Luxon which uses Intl for its timezones functionality. The timezones would not work without the env var, but when the env var is enabled and there is no lean-intl the timezones work.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Developers will now have the option to opt out of using lean-intl.